Add support for setting traffic class on outgoing packets #120
+55
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hipska
approved these changes
Sep 2, 2024
|
This needs a rebase. |
For networks where traffic can be classified, it is useful to define different probe priorities to test the network and validate that QoS configuration. The patch also set probe service class to `Network Control` (CS6) by default. Fix prometheus-community#41 Signed-off-by: Édouard Thuleau <[email protected]>
ethuleau
force-pushed
the
traffic-class
branch
from
be7b574 to
cd05b29
Compare
done @SuperQ |
Hipska
approved these changes
Oct 31, 2024
SuperQ
reviewed
Oct 31, 2024
| @@ -46,9 +45,13 @@ func main() { | |||
| size := flag.Int("s", 24, "") | |||
| ttl := flag.Int("l", 64, "TTL") | |||
| iface := flag.String("I", "", "interface name") | |||
| tclass := flag.Int("Q", 192, "Set Quality of Service related bits in ICMP datagrams (DSCP + ECN bits). Only decimal number supported") | |||
There was a problem hiding this comment.
I wonder if it would be better to make this a String() so we can parse both decimal and hex values like iputils does.
|
I guess we can improve on this later to support hex input. |
yes sorry I did not managed to get time work on this. I'm adding it to my todo list. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For networks where traffic can be classified, it is useful to define different probe priorities to test the network and validate that QoS configuration.
The patch also set probe service class to
Network Control(CS6) by default.Fix #41